This shows you the differences between two versions of the page.
Both sides previous revision Previous revision | |||
submitting-patches [2018/03/01 08:54] tmomas updated git link |
submitting-patches [2018/04/18 17:08] (current) tmomas LEDE -> OpenWrt |
||
---|---|---|---|
Line 1: | Line 1: | ||
====== Submitting patches ====== | ====== Submitting patches ====== | ||
- | Patches can be submitted as a pull request on Github or via the mailing list.\\ | + | Patches can be submitted as a pull request on Github or via the mailing list. |
Submissions should follow the following guidelines: | Submissions should follow the following guidelines: | ||
Line 28: | Line 28: | ||
* must have less than 75 characters per line | * must have less than 75 characters per line | ||
* it will be committed to the source changelog, so __it should explain to a competent reader why you made this commit__.\\ Include symptoms of the failure you are fixing (log messages, error messages, etc.), it will be useful for\\ people searching the commit logs looking for a fix for their issue.\\ If a patch fixes a compile failure, include only the most relevant part of the failure log | * it will be committed to the source changelog, so __it should explain to a competent reader why you made this commit__.\\ Include symptoms of the failure you are fixing (log messages, error messages, etc.), it will be useful for\\ people searching the commit logs looking for a fix for their issue.\\ If a patch fixes a compile failure, include only the most relevant part of the failure log | ||
- | * If you add support for new hardware: Include in your commit message a short description of the hardware and how to install LEDE on it. Have a look at the [[https://git.openwrt.org/?p=openwrt/openwrt.git&a=search&h=HEAD&st=commit&s=add+support+for|recent additions]] for some examples. | + | * If you add support for new hardware: Include in your commit message a short description of the hardware and how to install OpenWrt on it. Have a look at the [[https://git.openwrt.org/?p=openwrt/openwrt.git&a=search&h=HEAD&st=commit&s=add+support+for|recent additions]] for some examples. |
* **all commits must contain ''%%Signed-off-by: My Name <my@email.address>%%'' where you write your real name and real email address**, in accordance with [[http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=HEAD#n416|Section 11 of the Linux Kernel patches guide]]. | * **all commits must contain ''%%Signed-off-by: My Name <my@email.address>%%'' where you write your real name and real email address**, in accordance with [[http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=HEAD#n416|Section 11 of the Linux Kernel patches guide]]. |