Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision Next revision | Previous revision Next revisionBoth sides next revision | ||
| submitting-patches [2023/07/16 19:48] – [Submission Guidelines] Typo fix wirelessfreedom | submitting-patches [2024/06/17 08:59] – old revision restored (2024/01/03 07:44) svanheule | ||
|---|---|---|---|
| Line 8: | Line 8: | ||
| * **Patches to core packages and patches that add support for new devices** (i.e. code that is in [[https:// | * **Patches to core packages and patches that add support for new devices** (i.e. code that is in [[https:// | ||
| - | * **Patches for Luci web interface and related packages** can be submitted to mailing list or to the [[https:// | + | * **Patches for LuCI web interface and related packages** can be submitted to mailing list or to the [[https:// |
| - | * **Patches for community packages about routing** should go as a Github PR in the [[https:// | + | * **Patches for community packages about routing** should go as a Github PR in the [[https:// |
| - | * **Patches for community packages about telephony and SIP/VOIP** should go as a Github PR in the [[https:// | + | * **Patches for community packages about telephony and SIP/VOIP** should go as a Github PR in the [[https:// |
| - | * **Patches for miscellaneous community packages** should go as a Github PR in the [[https:// | + | * **Patches for miscellaneous community packages** should go as a Github PR in the [[https:// |
| <WRAP round info 60%> | <WRAP round info 60%> | ||
| Line 70: | Line 70: | ||
| - PRs can be sent to the patches mailing list from any source and will always be considered for inclusion if the quality of the tree is good and format of submission is correct | - PRs can be sent to the patches mailing list from any source and will always be considered for inclusion if the quality of the tree is good and format of submission is correct | ||
| - Staging trees can be hosted as part of the projects git infrastructure, | - Staging trees can be hosted as part of the projects git infrastructure, | ||
| + | ===== Patch backports ===== | ||
| + | Backporting refers to applying changes to a stable (release) branch like for example **openwrt-23.05** from the **main** branch. Since new features are not added to stable branches, backported changes are generally bug fixes and security fixes only. The process is roughly following: | ||
| + | - Changes needs to be first applied into the **main** branch | ||
| + | - Afterwards those changes can be proposed to be applied into the stable (release) branch | ||
| + | When pulling the commits from the **main** branch, you need to use '' | ||
| + | <code bash> | ||
| + | $ git cherry-pick --signoff -x < | ||
| + | </ | ||
| ===== Patch checklist ===== | ===== Patch checklist ===== | ||
| - Single commit ( multiple commits must first be squashed, as described [[docs: | - Single commit ( multiple commits must first be squashed, as described [[docs: | ||
| Line 190: | Line 197: | ||
| Large changes are not appropriate for mailing lists, and some maintainers. If your patch, uncompressed, | Large changes are not appropriate for mailing lists, and some maintainers. If your patch, uncompressed, | ||
| - | ==== 8. Don't get discouraged, re-submit ===== | + | ==== 8. Remain objective, re-submit ===== |
| + | |||
| + | It's nothing personal. Code should work well for its intended purpose and results should adhere to many standards and requirements, | ||
| After you have submitted your change, be patient and wait. If developers like your change and apply it, it will appear as new revision in the source code management system. | After you have submitted your change, be patient and wait. If developers like your change and apply it, it will appear as new revision in the source code management system. | ||