Differences

This shows you the differences between two versions of the page.

Link to this comparison view

docs:guide-developer:frequent-pr-mistakes [2021/06/28 20:22] – created adrianschmutzlerdocs:guide-developer:frequent-pr-mistakes [2023/03/19 22:40] (current) – rephrase to use gender neutral language ryanc
Line 51: Line 51:
 Maybe there is a need to change - but now the reviewers will probably be able to help you with what has to be done, since they have been given information. Maybe there is a need to change - but now the reviewers will probably be able to help you with what has to be done, since they have been given information.
  
-Thus, if you are asked "Have you tested this?", please answer. "Yes" or "no", and some explanation. If someone wanted you to change anything already, he would simply have said so.+Thus, if you are asked "Have you tested this?", please answer. "Yes" or "no", and some explanation. If someone wanted you to change anything already, they would simply have said so.
  
 ===== 6. Do not resolve comment that are not resolved ===== ===== 6. Do not resolve comment that are not resolved =====
Line 78: Line 78:
 Occasionally, people do 90 % of the requested changes and simply ignore the rest. Occasionally, people do 90 % of the requested changes and simply ignore the rest.
  
-Don't do that. It will waste the reviewer's life-time (since he has to come back for another round) and will have you waiting longer for a chance to be merged (since he has to come back for another round).+Don't do that. It will waste the reviewer's life-time (since they have to come back for another round) and will have you waiting longer for a chance to be merged (since they have to come back for another round).
  • Last modified: 2021/06/28 20:22
  • by adrianschmutzler